Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support returning computed distance and set distance thresholds on VectorQueries #960

Merged
merged 16 commits into from
Aug 26, 2024
Merged

feat: support returning computed distance and set distance thresholds on VectorQueries #960

merged 16 commits into from
Aug 26, 2024

Conversation

NickChittle
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@NickChittle NickChittle requested review from a team as code owners August 21, 2024 19:23
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/python-firestore API. labels Aug 21, 2024
daniel-sanche
daniel-sanche reviewed Aug 23, 2024
View reviewed changes
google/cloud/firestore_v1/async_query.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/base_vector_query.py Show resolved Hide resolved
tests/system/test_system.py Show resolved Hide resolved
google/cloud/firestore_v1/base_collection.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/base_vector_query.py Outdated Show resolved Hide resolved
@daniel-sanche daniel-sanche added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@daniel-sanche daniel-sanche enabled auto-merge (squash) August 26, 2024 16:39
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@daniel-sanche daniel-sanche merged commit 5c2192d into googleapis:main Aug 26, 2024
19 of 20 checks passed
@release-please release-please bot mentioned this pull request Aug 26, 2024
Merged
@NickChittle NickChittle deleted the vector_distance_params branch August 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@cindy-peng cindy-peng

Labels
api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickChittle @daniel-sanche @yoshi-kokoro @cindy-peng