Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support async vector search from a collection #949

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

NickChittle
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Previously we could only make an Async Vector Search from a Query (i.e. had a .where(...) clause beforehand)

@NickChittle NickChittle requested review from a team as code owners August 13, 2024 02:07
Copy link

conventional-commit-lint-gcf bot commented Aug 13, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 13, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 13, 2024
@daniel-sanche daniel-sanche changed the title Fix Async Vector search from a collection fix: support async vector search from a collection Aug 13, 2024
@NickChittle NickChittle changed the base branch from main to 387-restart-watch-stream-after-filter-mismatch August 13, 2024 17:57
@NickChittle NickChittle requested a review from a team as a code owner August 13, 2024 17:57
@NickChittle NickChittle requested review from m-strzelczyk and removed request for a team August 13, 2024 17:57
@NickChittle NickChittle changed the base branch from 387-restart-watch-stream-after-filter-mismatch to main August 13, 2024 17:57
@daniel-sanche daniel-sanche enabled auto-merge (squash) August 13, 2024 18:04
@daniel-sanche daniel-sanche added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2024
@daniel-sanche daniel-sanche merged commit 6446e29 into googleapis:main Aug 13, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants