chore(pubsub): rewrite v2 files with new package #11292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzmue
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the new v2 code to using the new cloud.google.com/go/pubsub/v2 package, and changes the appropriate GAPIC imports (e.g. Publisher -> TopicAdmin, Subscriber->SubscriptionAdmin).
This is one part of a series of changes to land the new v2 library in a way that makes the PRs easier to read and not too large.
Because this is happening in flight, this code will NOT currently compile. Future PRs will merge into the
pubsub-v2-trunkbranch.