fix(storage): migrate oauth2/google usages to cloud.google.com/go/auth #11191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
quartzmo
force-pushed
the
storage-new-auth
branch
from
cbc450e to
2f8457f
Compare
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Nov 26, 2024
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Nov 26, 2024
quartzmo
added a commit
to googleapis/google-api-go-client
that referenced
this pull request
Nov 26, 2024
BrennaEpp
reviewed
Dec 4, 2024
Comment on lines
+128
to
+132
| func (c Client) credsJSON() []byte { | ||
| if c.creds != nil && len(c.creds.JSON()) > 0 { | ||
| return c.creds.JSON() | ||
| } | ||
| return []byte{} |
There was a problem hiding this comment.
I think this would be nicer returning the creds and a bool so that callers can check creds, ok := credsJSON()
Suggested change
| func (c Client) credsJSON() []byte { | |
| if c.creds != nil && len(c.creds.JSON()) > 0 { | |
| return c.creds.JSON() | |
| } | |
| return []byte{} | |
| func (c Client) credsJSON() ([]byte, bool) { | |
| if c.creds != nil && len(c.creds.JSON()) > 0 { | |
| return c.creds.JSON(), true | |
| } | |
| return []byte{}, false |
| @@ -5728,7 +5751,7 @@ func TestIntegration_PostPolicyV4_WithCreds(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
| }, option.WithCredentials(creds)) | |||
| }, option.WithAuthCredentials(creds)) | |||
There was a problem hiding this comment.
Did you try running the integration tests without changes? I would like to make sure they pass even using the old auth before switching them over.
Signed URL stuff in particular, do you think it would be useful to test with both the old and new auth paths?
Comment on lines
+1295
to
+1297
| creds, err := credentials.DetectDefault(&credentials.DetectOptions{ | ||
| CredentialsJSON: jsonBytes, | ||
| }) |
There was a problem hiding this comment.
Is it possible to get auth credentials here without this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.