pkg/build/linux: support building with a custom make binary #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentRevest
force-pushed
the
custom-make
branch
2 times, most recently
from
377a0ea
to
92c50d7
Compare
Certain environments might need a specific make command or wrap make calls with extra logic. This lets users provide a path to a custom make binary.
FlorentRevest
force-pushed
the
custom-make
branch
3 times, most recently
from
1f8bd13
to
b2f262e
Compare
This unifies the build() and clean() interfaces such that if a custom compiler or make binary is provided in the manager or bisection config, they can be taken into account by the clean() interface.
FlorentRevest
force-pushed
the
custom-make
branch
from
b2f262e
to
7167531
Compare
FlorentRevest
requested review from
avagin,
blackgnezdo,
mptre,
markjdb,
tuexen,
mvanotti,
noncombatant,
glpesk and
eepeep
as code owners
a-nogikh
requested review from
a-nogikh
and removed request for
mptre,
tuexen,
noncombatant,
mvanotti,
markjdb,
avagin,
blackgnezdo,
eepeep and
glpesk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain environments might need a specific make command or wrap make calls with extra logic. This lets users provide a path to a custom make binary.