Completion Enhancements

[meshde]

Introduction

This PR changes the completion scripts that are generated by running the --completion option for the Fire generated commands. The changes are aimed to give more flexibility to the user.

Main Changes

• The highlight of this PR is the shift from using start based completion to last-command based completion.
• In the start based completion, the entire string that has been entered into the command prompt so far is used to map the completion suggestions. This creates inflexibility for the user, causing completion can not tab hint and complete the second param? #136.
• In the last-command based completion, suggestions are based on the last command/subcommand (non-option arg) entered by the user. This gives flexibility to the user, to be able to use options in any order, thereby fixing completion can not tab hint and complete the second param? #136.

Features

The features added are:

• Ability to use options in any order.
• Options that are already entered are not shown in the suggestion list.
• The completion script abides by the usage of Fire generated CLI commands, such that function arguments are removed from the suggestion list once a module level option (or global option) is entered. In other words, module options come either before a function or after it's arguments (see guide)
• All the above included for both: bash & fish

[dbieber]

This is great, thanks for the PR! I'll take a closer look after the weekend.

[dbieber]

Apologies for the delay; I haven't had a chance to look in detail at this yet.

[meshde]

No worries 😄

In the meantime, I could also have a look at #148 and resolve it in the same PR.

[dbieber]

That would be awesome :)

[dbieber]

Heads up some of the tests are failing in Python 3.6
E TypeError: unsupported operand type(s) for +: 'dict_keys' and 'dict_keys'
https://travis-ci.org/google/python-fire/jobs/448120104

[meshde]

Heads up some of the tests are failing in Python 3.6

Fixed them now. All tests passing!

[dbieber]

I apologize I messed up with the merge.

[dbieber]

If you rebase 1024dda onto google/python-fire:master then I will squash and merge.

Edit: I did the first half of that (rebased 1024dda onto google/python-fire:master). Hope you don't mind me making those changes on your fork of the repo.

[dbieber]

merged!