Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zstd): Upgrade numcodecs.js to 0.3.2 for Zstd streaming decompression #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link

@mkitti mkitti commented Aug 15, 2024

Fix #625

Upgrade numcodecs.js to version 0.3.2

Version 0.3.2 incorporates manzt/numcodecs.js#47 which supports detection of
ZSTD_CONTENTSIZE_UNKNOWN from ZSTD_getFrameContentSize.

Zstd decompression is now handled via the advanced streaming API so that the entire buffer size does
not need to be known ahead of time.

Incorporating this allows Neuroglancer to read Zstd compressed data from Tensorstore. However, this not resolve
google/tensorstore#182 . Other Zarr implementations such as zarr-python continue to
have issues:
zarr-developers/zarr-python#2056

Copy link

google-cla bot commented Aug 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mkitti mkitti changed the title Fix #625: Upgrade numcodecs.js to 0.3.2 for Zstd streaming decompression support fix(zstd): Upgrade numcodecs.js to 0.3.2 for Zstd streaming decompression Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zstd decompression fails due to unknown frame content size
1 participant