feat(datasource/graphene) find path tool #474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, factoring out makeAnnotationListElement seems to make sense to me. |
chrisj
force-pushed
the
cj_find_path_2
branch
3 times, most recently
from
0f82af1
to
fd723ef
Compare
|
@jbms this should be ready now I set up clang-format to run on save, so this includes a bit of formatting changes though I can back those out if you prefer |
chrisj
commented
Nov 24, 2023
src/neuroglancer/ui/annotations.ts
Outdated
| selectionState.annotationId === annotation.id) { | ||
| element.classList.add('neuroglancer-annotation-selected'); | ||
| } | ||
| return element; |
There was a problem hiding this comment.
moved a few things outside of makeAnnotationListElement that were more closely related to the list
jbms
reviewed
Nov 29, 2023
| @@ -61,6 +65,7 @@ import {Uint64} from 'neuroglancer/util/uint64'; | |||
| import {makeDeleteButton} from 'neuroglancer/widget/delete_button'; | |||
| import {DependentViewContext} from 'neuroglancer/widget/dependent_view_widget'; | |||
| import {makeIcon} from 'neuroglancer/widget/icon'; | |||
| import {CancellationToken, CancellationTokenSource} from 'src/neuroglancer/util/cancellation'; | |||
There was a problem hiding this comment.
fix src/neuroglancer/ path to neuroglancer/
There was a problem hiding this comment.
Done, I'm also going to put up a pull request to fix some other imports.
|
This PR is ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool finds a path between 2 points on the same segment.
I crudely copied AnnotationLayerView.makeAnnotationListElement to create some annotation widgets for this tool. It seems to work fairly well as a UI element. Do you think I should continue and fully move makeAnnotationListElement outside of AnnotationLayerView? Or would it be better to create my own element.