Move to use (experimental) workspaces #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
force-pushed
the
workspaces
branch
2 times, most recently
from
a3d225c
to
7895318
Compare
kevmoo
commented
Aug 5, 2024
| @@ -153,14 +156,21 @@ String _classCleanAndSort(Iterable<String> classes) { | |||
| extension on BuildStep { | |||
| AssetId assetIdForInputPackage(String path) => AssetId(inputId.package, path); | |||
|
|
|||
| // WARNING! This function does BAD THINGS | |||
There was a problem hiding this comment.
Not my best work...but 🤷
There was a problem hiding this comment.
Looking at this code, there might actually be a proper way to do it. The JSON annotation package could make its own pubspec.yaml file public (readable) using the additional_public_assets option.
I think you could just add into its build.yaml file:
additional_public_assets:
- pubspec.yamlAnd then you could read it just like buildStep.readAsString(AssetId('json_annotation', 'pubspec.yaml'))?
You would have to require the latest json_annotation, which adds the public asset.
jakemac53
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.