-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-CN: Update po/zh-CN.po #1974
base: main
Are you sure you want to change the base?
Conversation
Update the Simplified Chinese edition of some segments: "Welcome to Comprehensive Rust", "Day 1 Morning", "Day 1 Afternoon" and "Day 2 Morning". Correct some mistakes in previous translated version as well.
Co-authored-by: Yi Kong <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @illustager, thanks for fixing the merge conflicts! I noticed that this PR changes some of the timing information tables: #: src/running-the-course/course-structure.md
msgid "[Tuples and Arrays](../tuples-and-arrays.md) (1 hour)"
-msgstr "[元组和数组](../tuples-and-arrays.md)(1 小时)"
+msgstr "[元组和数组](../tuples-and-arrays.md) (1 hour)"
#: src/running-the-course/course-structure.md
msgid "[References](../references.md) (50 minutes)"
-msgstr "[引用](../references.md)(50 分钟)"
+msgstr "[引用](../references.md) (50 minutes)"
#: src/running-the-course/course-structure.md
msgid "[User-Defined Types](../user-defined-types.md) (50 minutes)"
-msgstr "[用户定义的类型](../user-defined-types.md)(50 分钟)"
+msgstr "[用户定义的类型](../user-defined-types.md) (50 minutes)" It seems you're changing the translation of "minutes" back to English, but I'm not sure this is on purpose? |
It's a bit unfortunate that those tables end up in the translation file at all, I filled #1982 to see if we can improve this. |
It looks like some of the translation is rolled back in this PR. |
I looked through
and the PR here seems to undo some translations. I think it needs to be rebased on top of the latest |
Fix merge conflict. Apply the review comments.