Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: Update po/zh-CN.po #1974

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

zh-CN: Update po/zh-CN.po #1974

wants to merge 15 commits into from

Conversation

illustager
Copy link

Fix merge conflict. Apply the review comments.

Copy link

google-cla bot commented Apr 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mgeisler
Copy link
Collaborator

Hi @illustager, thanks for fixing the merge conflicts!

I noticed that this PR changes some of the timing information tables:

 #: src/running-the-course/course-structure.md
 msgid "[Tuples and Arrays](../tuples-and-arrays.md) (1 hour)"
-msgstr "[元组和数组](../tuples-and-arrays.md)(1 小时)"
+msgstr "[元组和数组](../tuples-and-arrays.md) (1 hour)"
 
 #: src/running-the-course/course-structure.md
 msgid "[References](../references.md) (50 minutes)"
-msgstr "[引用](../references.md)(50 分钟)"
+msgstr "[引用](../references.md) (50 minutes)"
 
 #: src/running-the-course/course-structure.md
 msgid "[User-Defined Types](../user-defined-types.md) (50 minutes)"
-msgstr "[用户定义的类型](../user-defined-types.md)(50 分钟)"
+msgstr "[用户定义的类型](../user-defined-types.md) (50 minutes)"

It seems you're changing the translation of "minutes" back to English, but I'm not sure this is on purpose?

@mgeisler
Copy link
Collaborator

It's a bit unfortunate that those tables end up in the translation file at all, I filled #1982 to see if we can improve this.

@mobyw
Copy link
Contributor

mobyw commented Apr 14, 2024

It looks like some of the translation is rolled back in this PR.
You can select the lines that need to be changed, find the corresponding location in the latest branch and paste it in and make the changes.

@mgeisler
Copy link
Collaborator

I looked through

gh pr diff 1974 | bat -l patch

and the PR here seems to undo some translations. I think it needs to be rebased on top of the latest main. Please see #1948 (comment) for a recipe on how to hand-merge the PO files, if the conflicts are complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants