Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions in unary RPC error tests #44

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add assertions in unary RPC error tests #44

merged 1 commit into from
Dec 13, 2023

Conversation

andrewheard
Copy link
Collaborator

  • Added assertions verifying returned RPCErrors in unary calls
  • Changed from Int32 to Int in RPCError

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 12, 2023
@paulb777
Copy link
Collaborator

Going to merge in advance of upcoming tag.

@paulb777 paulb777 merged commit ab1c139 into main Dec 13, 2023
8 checks passed
@paulb777 paulb777 deleted the ah/test-unary-rpc-error branch December 13, 2023 00:07
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777