Support file uploads using a stream #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation requires a file to exist in the local filesystem, which is an uncommon scenario for production use cases. This adds the ability to supply the upload contents as a node stream, and improves the filesystem case by streaming instead of loading into memory.
|
Heyo - I just want to check whether a streaming approach is something that will be considered in this project. We've been patching this locally during development, but if this is unlikely to be merged or made possible through an alternate implementation, we'll just go ahead and publish a fork of this package. |
|
In case it's helpful to anyone, here's a pretty straightforward workaround, largely just copying the existing implementation. |
|
Really appreciate you trying to PR this, and thank you for the workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation requires a file to exist in the local filesystem, which is an uncommon scenario for production use cases. Instead, files are typically either stored in an appropriate external storage system like GCS or are supplied directly by the user over the network.
This change adds the ability to supply a file upload as a stream, and improves the existing filesystem flow by streaming the file's contents rather than attempting to load it into memory first (it was previously using the blocking call, which is only really appropriate for init stage file loading, quick demos, or systems that don't need to support concurrent requests).