UsageMetadata - add cachedContentTokenCount field #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
changed the title
hsubox76
reviewed
Jun 21, 2024
packages/main/types/responses.ts
Outdated
| @@ -98,6 +98,8 @@ export interface UsageMetadata { | |||
| candidatesTokenCount: number; | |||
| /** Total token count for the generation request (prompt + candidates). */ | |||
| totalTokenCount: number; | |||
| /** Total token count in the cached part of the prompt, i.e. in the cached content. */ | |||
| cachedContentTokenCount: number; | |||
There was a problem hiding this comment.
One thing just occurred to me, are these in fact always populated? (I'm not even sure about the previously existing fields here.) I know the proto doesn't list any of these as optional but it doesn't seem like these would always be populated in actual practice. If not we should probably make it optional. I did a quick test against autopush not using cached content and I got back the 3 other properties but not this one.
There was a problem hiding this comment.
Yeah, it's not always populated. I figured if this was a problem then the non-cached-content integration tests would have failed.
I can make it optional.
hsubox76
approved these changes
Jun 22, 2024
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
This was referenced Sep 18, 2024
This was referenced Sep 23, 2024
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
cachedContentTokenCountfield to theUsageMetadatainterface returned bygenerateContentresponses.