Cleanup CI workflows #321
Merged
Cleanup CI workflows #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gaby
commented
Jan 7, 2024
•
gaby
commented
- Remove redundant comments.
- Fix go-versions inconsistency across ci files.
- Add '*' for branches in pull request.
- Add govulncheck workflow.
- Rename workflows with the tool name.
- Merge changes from Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 #319 here
gaby
commented
Jan 7, 2024
| @@ -27,9 +27,6 @@ jobs: | |||
| with: | |||
| node-version: '18' | |||
|
|
|||
| - name: Install JQ | |||
| run: sudo apt-get install jq | |||
There was a problem hiding this comment.
Runners have jq pre-installed.
|
@ReneWerner87 I noticed the tests didn't run in #316 when i added the "*" rule for pull-requests branches it triggered the CI. Thus why I did this PR |
|
@ReneWerner87 Should we add a rule that benchmarks only run if changes to |
|
Yes sounds good |
ReneWerner87
approved these changes
Jan 7, 2024
|
@efectn @ReneWerner87 Done, benchmark will only run on changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.