goenv-init: Fix use of optional variables that should not crash the calling shell if unset #431
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamandar
requested review from
syndbg,
ChronosMasterOfAllTime and
reneleonhardt
as code owners
|
@Salamandar please fix the failing unit tests. |
…alling shell if unset
Just use the ${variable:-} syntax to accept unset variables
Salamandar
force-pushed
the
fix_set_u
branch
from
faaad76 to
57e68c2
Compare
|
Should be fine now. Just have to wait for the CI to confirm it. |
|
Hmmmm the CI does not want to start? |
ChronosMasterOfAllTime
approved these changes
Dec 26, 2024
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just use the ${variable:-} syntax to accept unset variables
Our Yunohost helper is broken since the 2.2.10 because we source goenv-init with
set -uand we don't define the optional environment variables.