Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary query #17660

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

knewbury01
Copy link
Contributor

@knewbury01 knewbury01 commented Oct 3, 2024

Pull Request checklist

does a query removal require a changenote? added

I propose removing this query, as it is subsumed by the logic of EmptyBlock which does also cover statements

ran these both using MRVA on top 10 java repos

and did a check explicitly on all results from junit-team/junit4 database that the result set of EmptyBlock completely subsumed the results of the removed query

suspect it will be similar for other databases (though encourage anyone else to double check my logic on this as well)

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

QHelp previews:

@owen-mc
Copy link
Contributor

owen-mc commented Oct 3, 2024

Yes, it does need a change note, in case people wonder why they've lost some results.

@knewbury01
Copy link
Contributor Author

Yes, it does need a change note, in case people wonder why they've lost some results.

thanks! I wasnt totally sure what changenote category to use here

I see in the doc that normally a query deletion is breaking, but this query doesnt seem to be in a pack (searching via the action artifact code scanning query list) , so I used minorAnalysis... let me know if that was not correct! thanks!

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants