Rust: Add {BreakExpr,ContinueExpr}.getTarget()
#17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/break-continue-target
branch
from
053e6da
to
5abaea3
Compare
hvitved
force-pushed
the
rust/break-continue-target
branch
from
5abaea3
to
6da3972
Compare
geoffw0
reviewed
Oct 3, 2024
| } | ||
|
|
||
| override predicate last(AstNode last, Completion c) { none() } |
There was a problem hiding this comment.
Is having no last node valid?
There was a problem hiding this comment.
Yes, and we want it because the edge out of {Break,Continue}Expr is defined explicitly (as the jump target) in the succ relation.
There was a problem hiding this comment.
Ah, having a last node would cause an (incorrect) edge to be created from the break to the next statement sequentially in the program.
geoffw0
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is convenient to be able to resolve the target of a
breakorcontinueexpression, without relying on the CFG. This furthermore allows for the CFG construction to be simplified.