Rust: Implement UnusedVariable.ql
#17642
Merged
+282
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/unused-variable
branch
from
d7c304c
to
8634dd5
Compare
hvitved
force-pushed
the
rust/unused-variable
branch
from
8634dd5
to
fb9ec24
Compare
geoffw0
reviewed
Oct 2, 2024
| /** Holds if `e` occurs in the LHS of a (compound) assignment. */ | ||
| private predicate assignLhs(Expr e) { | ||
| exists(BinaryExpr be | | ||
| be.getOperatorName().regexpMatch(".*=") and |
There was a problem hiding this comment.
I don't feel strongly about this one, but I believe matches is still preferred over regexpMatch where possible???
Suggested change
| be.getOperatorName().regexpMatch(".*=") and | |
| be.getOperatorName().matches("%=") and |
There was a problem hiding this comment.
I would expect matches to do the same thing.
There was a problem hiding this comment.
Yep, there was a discussion a long while back about whether the optimiser is more aware of matches, I can't remember the answer. Anyway, up to you.
geoffw0
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this query is based entirely on syntax, we can implement it already now without SSA.