Java: sanitize values which are checked against an allowlist (currently only java.util.List.contains) #17051
+911
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
force-pushed
the
java/allow-list-sanitizer
branch
from
9e85afb
to
d062b8b
Compare
owen-mc
changed the title
List.contains on a list constructed locally with List.of)![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
owen-mc
force-pushed
the
java/allow-list-sanitizer
branch
from
d062b8b
to
f523ff3
Compare
| or | ||
| collectionClass = "Set" and | ||
| t.hasQualifiedName("java.util", "Set") and | ||
| m.getName() = ["add"] and |
Check warning
Code scanning / CodeQL
Singleton set literal Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking that a value is in a set of compile-time constant values should be a sanitizer, because what was untrusted data has now been checked to be in a known set of values. It is hard in CodeQL to identify when this happens, as there are many ways of checking that a value is in a known set of values. This PR introduces the framework for this sanitizer and implements it for a small number of cases:
containson ajava.util.Listwhich contains only compile-time constant valuesList.of(...)orCollections.unmodifiableList(Arrays.asList(...)), either created locally or read from a final static field.Listwhich has had elements added usingadd, and they are all constants.