Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move DI to init() to make Pagination Comp working with all ports #1716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 17, 2024

  • after giving it a try in Angular/Aurelia-Slickgrid, I discovered that it was better to avoid using any DI, we can simply move them to an init() function

Copy link

stackblitz bot commented Oct 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (a0a595e) to head (cd30686).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1716     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       31098   31105      +7     
  Branches     9760    9763      +3     
========================================
+ Hits        31009   31016      +7     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant