ref(anyhow): Disable anyhow's backtrace feature #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
avoid-downloading-anyhow-backtrace-dependency
branch
from
f74e622
to
d7a807d
Compare
Since anyhow 1.0.77, backtrace feature is not needed for Rust 1.65+ (https://github.com/dtolnay/anyhow/releases/tag/1.0.77). Because sentry has a higher MSRV than that, it's no longer necessary to enable this feature.
KamilaBorowska
force-pushed
the
avoid-downloading-anyhow-backtrace-dependency
branch
from
d7a807d
to
7687a7a
Compare
|
It might not be necessary, but I doubt it hurts to keep it? I would have to take a closer look at this in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since anyhow 1.0.77, backtrace feature is not needed for Rust 1.65+ (https://github.com/dtolnay/anyhow/releases/tag/1.0.77). Because sentry has a higher MSRV than that, it's no longer necessary to enable this feature.