Feat/only send debug images referenced in the stacktrace for events #2329
+68
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Feat/only send debug images referenced in the stacktrace for events ([#2329](https://github.com/getsentry/sentry-dart/pull/2329))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
===========================================
- Coverage 86.38% 63.31% -23.08%
===========================================
Files 247 4 -243
Lines 8615 169 -8446
===========================================
- Hits 7442 107 -7335
+ Misses 1173 62 -1111 ☔ View full report in Codecov by Sentry. |
martinhaintz
commented
Oct 7, 2024
martinhaintz
commented
Oct 7, 2024
|
@buenaflor any ideas, what would be the best way to test this? |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 31b2afb | 397.04 ms | 475.09 ms | 78.04 ms |
| b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
| e6b16cd | 523.24 ms | 594.77 ms | 71.53 ms |
| 3f23617 | 385.77 ms | 476.10 ms | 90.33 ms |
| ecb4003 | 332.58 ms | 385.15 ms | 52.57 ms |
| be8cafe | 405.40 ms | 470.95 ms | 65.56 ms |
| 4b943a1 | 348.17 ms | 437.15 ms | 88.98 ms |
| c978477 | 347.00 ms | 409.94 ms | 62.94 ms |
| 746a779 | 347.94 ms | 385.71 ms | 37.78 ms |
| 90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 31b2afb | 6.34 MiB | 7.28 MiB | 966.36 KiB |
| b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
| e6b16cd | 6.35 MiB | 7.33 MiB | 1005.63 KiB |
| 3f23617 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| ecb4003 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| be8cafe | 6.34 MiB | 7.29 MiB | 969.12 KiB |
| 4b943a1 | 6.34 MiB | 7.28 MiB | 968.41 KiB |
| c978477 | 6.33 MiB | 7.29 MiB | 987.32 KiB |
| 746a779 | 6.27 MiB | 7.20 MiB | 956.05 KiB |
| 90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c57d3b7 | 1249.92 ms | 1280.31 ms | 30.39 ms |
| 6f3717a | 1259.84 ms | 1280.90 ms | 21.06 ms |
| 3e33891 | 6245.86 ms | 6260.90 ms | 15.04 ms |
| bffc2c5 | 1239.76 ms | 1264.67 ms | 24.92 ms |
| 6fedcab | 1242.33 ms | 1269.66 ms | 27.33 ms |
| 9f9f94f | 1268.33 ms | 1284.73 ms | 16.41 ms |
| 55cc6ef | 1271.92 ms | 1281.04 ms | 9.12 ms |
| d53c6fa | 1254.86 ms | 1270.83 ms | 15.97 ms |
| a817b8f | 1261.90 ms | 1264.62 ms | 2.73 ms |
| 117d988 | 1200.83 ms | 1223.24 ms | 22.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c57d3b7 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
| 6f3717a | 8.33 MiB | 9.62 MiB | 1.29 MiB |
| 3e33891 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| bffc2c5 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 6fedcab | 8.32 MiB | 9.50 MiB | 1.18 MiB |
| 9f9f94f | 8.15 MiB | 9.15 MiB | 1020.76 KiB |
| 55cc6ef | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| d53c6fa | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| a817b8f | 8.29 MiB | 9.37 MiB | 1.07 MiB |
| 117d988 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
vaind
reviewed
Oct 7, 2024
| if (images != null) { | ||
| return event.copyWith(debugMeta: DebugMeta(images: images)); | ||
| } | ||
| } | ||
|
|
||
| return event; | ||
| } | ||
|
|
||
| Set<String> _collectImageAddressesFromStackTrace(SentryStackTrace trace) { |
There was a problem hiding this comment.
maybe pass the set as an argument to avoid creating intermediate sets on each invocation.
There was a problem hiding this comment.
@vaind can you please explain it a little bit more, what you mean? Thanks.
There was a problem hiding this comment.
void _collectInstructionAddresses(
SentryEvent event,
Set<String> instructionAddresses,
)he probably means like this
vaind
reviewed
Oct 7, 2024
…e-for-events' of https://github.com/getsentry/sentry-dart into feat/only-send-debug-images-referenced-in-the-stacktrace-for-events * 'feat/only-send-debug-images-referenced-in-the-stacktrace-for-events' of https://github.com/getsentry/sentry-dart: Fix TTID timing issue (#2326) fix: dart2wasm test (#2327) Deprecate: metrics api (#2312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Instead of sending all debug images in case of errors, we only want to send the referenced debug images of the stacktrace to be sent.
💡 Motivation and Context
close #1755
💚 How did you test it?
??
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps