Sign bundles published from archives and during copy #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code flow for publishing from archives is different from publishing from a porter bundle definition. This resulted in signing never happened when publishing from an archive. This change introduces the signing when publishing from archives too. Signed-off-by: Kim Christensen <[email protected]>
When a bundles is published from an archive the invocation image is relocated and we cannot expect the invocation image to be called the same as defined directly by the bundle. Signed-off-by: Kim Christensen <[email protected]>
Update the integration test to also verify signing of bundles published from archives Signed-off-by: Kim Christensen <[email protected]>
…ndles Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
signBundlesPublishedFromArchives
branch
from
e2ea497
to
c0feb36
Compare
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Make it possible to sign bundles during copy between repositories. This is handle by creating a new signature, NOT by copying the potential existing signature. This is done for two reasons: 1. A signature might not be present on the source bundle 1. Repositories might use different digest algorithms or calculate the digest differently Signed-off-by: Kim Christensen <[email protected]>
kichristensen
changed the title
schristoff
reviewed
Aug 23, 2024
Instead bundle image should be used Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
signBundlesPublishedFromArchives
branch
from
84205f4
to
9d5af30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Support signing and verifying bundles published from archives.
Also adds support for signing bundles during copy
This is handle by creating a new signature, NOT by copying the potential existing signature. This is done for two reasons:
What issue does it fix
Closes #3201
Closes #3203
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist