Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: select_object_content() now returns the proper Stats #8436

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8291

@bblommers bblommers added this to the 5.0.25 milestone Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (1e4364d) to head (a253a7d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8436   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1167     1168    +1     
  Lines      101685   101707   +22     
=======================================
+ Hits        96198    96220   +22     
  Misses       5487     5487           
Flag Coverage Δ
servertests 28.82% <21.05%> (-0.01%) ⬇️
unittests 94.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers marked this pull request as ready for review December 26, 2024 18:54
@bblommers bblommers merged commit 0b2b687 into getmoto:master Dec 26, 2024
53 checks passed
@bblommers bblommers deleted the s3-bytes-scanned branch December 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 "select_object_content" Bytes data returns hardcoded values
1 participant