Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSQL: implement get_cluster() #8431

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

cm-iwata
Copy link
Contributor

This PR is part of #8413

add DSQL get_cluster() implementation.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (1e4364d) to head (e7996c0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8431   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1167     1168    +1     
  Lines      101685   101701   +16     
=======================================
+ Hits        96198    96214   +16     
  Misses       5487     5487           
Flag Coverage Δ
servertests 28.82% <0.00%> (-0.01%) ⬇️
unittests 94.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for continuing to build this out @cm-iwata

@bblommers bblommers added this to the 5.0.25 milestone Dec 24, 2024
@bblommers bblommers merged commit 459c900 into getmoto:master Dec 24, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants