DSQL: implement create_cluster() #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-iwata
commented
Dec 22, 2024
| @@ -45,6 +45,7 @@ | |||
| ("directconnect", re.compile("https?://directconnect\\.(.+)\\.amazonaws\\.com")), | |||
| ("dms", re.compile("https?://dms\\.(.+)\\.amazonaws\\.com")), | |||
| ("ds", re.compile("https?://ds\\.(.+)\\.amazonaws\\.com")), | |||
| ("dsql", re.compile("https?://dsql\\.(.+)\\.api\\.aws")), | |||
There was a problem hiding this comment.
DSQL Endpoint is sub domain of api.aws like dsql.us-east-1.api.aws not amazonaws.com
There was a problem hiding this comment.
Interesting. I wonder whether that's an outlier, or whether they're going to host other (existing?) services there as well.
cm-iwata
force-pushed
the
feat/add-dsql
branch
from
6a1a610 to
4a77181
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8425 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 1163 1167 +4
Lines 101638 101697 +59
=======================================
+ Hits 96152 96210 +58
- Misses 5486 5487 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #8413
add DSQL
create_cluster()implementation.