EC2: Remove internal Network Interface traces from the Subnet after deletion #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8415 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 1163 1163
Lines 101636 101638 +2
=======================================
+ Hits 96147 96149 +2
Misses 5489 5489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM - thank you for following up on this and fixing this completely @wandhydrant!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Issue #7896 was not completely fixed, the test code in the bug report did not run completely through. The fixed IP address of the deleted instance was still kept in an internal field of the Subnet, so that another instance with the same IP address could not get created.
I tried fixing this, and added a test. All EC2 tests pass, except two that seem unrelated and also fail for me on current master (one in test_availability_zones_and_regions.py and one in test_security_groups.py).
Thanks!