Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExposeHeader XML tag in S3 GetBucketCors response #8407

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kangasta
Copy link
Contributor

Remove extra d from ExposeHeader XML tag in GetBucketCors response.

@kangasta kangasta changed the title Fix ExposeHeader XML tag Fix ExposeHeader XML tag in S3 GetBucketCors response Dec 16, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (479c211) to head (c0e3e52).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8407   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files        1163     1163           
  Lines      101636   101638    +2     
=======================================
+ Hits        96147    96149    +2     
  Misses       5489     5489           
Flag Coverage Δ
servertests 28.83% <ø> (+<0.01%) ⬆️
unittests 94.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - looks like this has been broken forever.

Can you also improve the existing boto3-test and assert that the ExposeHeader is now correctly returned?

resp = s3_client.get_bucket_cors(Bucket=bucket_name)

We currently only assert that any CORSRules are returned, but we don't validate whether it actually returns the correct values.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thank you so much for the fix @kangasta!

@bblommers bblommers added this to the 5.0.24 milestone Dec 18, 2024
@bblommers bblommers merged commit 08a8506 into getmoto:master Dec 18, 2024
50 of 51 checks passed
@kangasta kangasta deleted the s3-ExposeHeader branch December 18, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants