Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RDS test clients with fixture #8406

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

snordhausen
Copy link
Contributor

Create RDS test clients with a fixture to get rid of copy&paste code in the tests. The variable is now consistently called client.

...and standardize on "client" instead of "conn". These tests
now run in a different region, but they are still passing.
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (479c211) to head (7b25083).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8406      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.03%     
==========================================
  Files        1163     1163              
  Lines      101636   101636              
==========================================
- Hits        96147    96119      -28     
- Misses       5489     5517      +28     
Flag Coverage Δ
servertests ?
unittests 94.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snordhausen
Copy link
Contributor Author

I'll look into what's breaking the server tests, I can reproduce the issue locally.

@bpandola
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants