Techdebt: allow test & lint to run for specific service #6024
Conversation
Makefile
Outdated
| @echo "Running MyPy..." | ||
| mypy --install-types --non-interactive | ||
| mypy --install-types --non-interactive moto/${SERVICE_NAME} |
There was a problem hiding this comment.
Not all services support typing at the moment - the ones that do are listed in setup.cfg. This is a very quick check, it only takes a few seconds, so I would suggest to just leave this as is.
There was a problem hiding this comment.
changed it a bit, but we can go this route as well.
make test SERVICE_NAME=s3
make test SERVICE_NAME=s3
make test SERVICE_NAME=s3
- mypy was configred via `files` which fails when specifying a target dir. Now turned into an exclude in the config, and adding explicit files to the Makefile when a service is selected. - added SKIP_MYPY to be able to skip mypy check (as long as the mypy chnage is not complete) - using conftest.py to give all the tests default markers - the include/exclude from the makefile is now in the conftest.py marking as well - for services, also picking up test that reference that service in its name (specific pattern)
| parallel_server_only: can be run in parallel (in server mode only) | ||
| skip_server: should not be run in server mode | ||
| # services | ||
| acm: acm service |
There was a problem hiding this comment.
Can we get this feature without listing all services? This would be a pain to maintain, considering the list changes quite often
There was a problem hiding this comment.
pytest will complain if these marks are not specified. Perhaps I can add something to ease this maintenance (or at least check all are there)
| @@ -229,7 +352,14 @@ disable = W,C,R,E | |||
| enable = anomalous-backslash-in-string, arguments-renamed, dangerous-default-value, deprecated-module, function-redefined, import-self, redefined-builtin, redefined-outer-name, reimported, pointless-statement, super-with-arguments, unused-argument, unused-import, unused-variable, useless-else-on-loop, wildcard-import | |||
|
|
|||
| [mypy] | |||
| files= moto/a*,moto/b*,moto/c*,moto/d*,moto/e*,moto/f*,moto/moto_api,moto/neptune | |||
| files= moto/a*,moto/b*,moto/c*,moto/d*,moto/e*,moto/moto_api,moto/neptune | |||
There was a problem hiding this comment.
This changes often as well, we're continuously adding typing support for new services, so I'd rather to just have a simple list. Having to understand and get the regex right isn't worth the effort
There was a problem hiding this comment.
good point, will revert this bit
|
While I appreciate the spirit of this PR, I think it's too big of a change and too much of a future maintenance hassle for the benefits. Locally testing just the service you've worked on is already quite simple, e.g.
Happy to consider better arguments for the need here, but I'm not currently in support of this. |
|
The tagging of resources comes into play, eg when not just wanting to run all cloudformation tests in the tests_cloudformation folder, but also related test in other folders (or for sns, lambda, ....) A similar list for the services already needs to be maintained for the dependencies. We can piggyback on that re checking for completeness / use the an additional check that also validates that this list dependency list is complete (not re the dependencies added, but at least having an entry present). |
|
shall I revert to the first one? |
|
Yes, let's, @hans-d, I think that's better. |
make test SERVICE_NAME=s3