Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC/Draft for configuration utility #3546

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BeyondEvil
Copy link

@bblommers made a wish and I figured why not get the ball rolling?

@coveralls
Copy link

coveralls commented Dec 14, 2020

Coverage Status

Coverage decreased (-0.002%) to 94.562% when pulling 218cb36 on BeyondEvil:config-rfc into a31599d on spulec:master.

@BeyondEvil
Copy link
Author

BeyondEvil commented Dec 14, 2020

Server tests are failing, likely due to the configuration.ini file missing or being in a different/wrong location.

Before I spend time debugging, maybe someone else can chime in with the correct solution to the problem? Afaict it should be present. The docker has the entire repo swallowed and I added the file to the MANIFEST.

Fixed.

@bblommers bblommers requested a review from spulec December 15, 2020 07:55
@BeyondEvil
Copy link
Author

Ping @spulec

@spulec
Copy link
Collaborator

spulec commented Feb 14, 2021

So far we have been using the settings file for this type of thing: https://github.com/spulec/moto/blob/master/moto/settings.py

Any thoughts on why this would be better? Or is this something else where it isn't designed to be configurable by the user?

@BeyondEvil
Copy link
Author

So far we have been using the settings file for this type of thing: https://github.com/spulec/moto/blob/master/moto/settings.py

Any thoughts on why this would be better? Or is this something else where it isn't designed to be configurable by the user?

A couple of things off the top of my head:

  • Provides support for different configurations between Production and Development/Test
  • Uses a more idiomatic approach to configuration

Wether or not it's user-configurable is really up to us (implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants