#265 LDAP groups and roles concepts are mixed

[etj]

Proposed changes:

• Separating mappers for roles and concepts
• Added configuration to prevent unmapped authorities to be stored
• Keep older bean definition in place for back compatibility
• Improved logging

---

After upgrading, if you don't change your xml configuration, you may get this error in the logfile:
AuthoritiesMapper is deprecated, please set roleMapper and groupMapper separately

This means you have, in the geostoreLdapProvider bean definition, the setter for the property authoritiesMapper (which is now deprecated).
In order to maintain the old behaviour, the authoritiesMapper will set the new 2 properties, roleMapper and groupMapper, that can now be separately defined.

Once the fix is applied, you may want to:

In geostoreLdapProvider, change the entry:

   <property name="authoritiesMapper" ref="rolesMapper"/>

to

   <property name="roleMapper" ref="rolesMapper"/>

In the rolesMapper bean, add the property:

   <property name="dropUnmapped" value="true" />

[nmco]

A couple of things are not clear here:

• For which client is this? The label on THE ISSUE?
• The testing doesn't seem to be complete enough.
• Why is this PR not targeting the master branch?

[simboss]

• C047-CLEVELAND-METROPARKS-2021-SUPPORT
• this is a priority fix for a production issue for which we can't wait weeks to deliver so it is targeting directly the branch they are using since we are delivering a patch quickly but we are sharing this with the team to properly clean, test and port on all active branches later on

@etj please, provide more info next time ( see our yesterday discussion on delegation)

[ale-cristofori]

A couple of things are not clear here:

• For which client is this? The label on THE ISSUE?
• The testing doesn't seem to be complete enough.

here more info https://github.com/geosolutions-it/MapStore2-C047/issues/28

Why is this PR not targeting the master branch?

thanks Notes for developers, Cleveland are using geostore version 1.7.1, the PR associated to this issue has to be forward ported to main branch.

[nmco]

Since this is super urgent I would recommend that you do as I told you on the chat @ale-cristofor, merge it a deploy it where you need it, then open an issue describing that we need to handle this properly:

• Bring this to master
• Add the necessary tests

[ale-cristofori]

the geostore jar file in this MapStore down stream project (located at C:\Users\acristofori\Development\MapStore2-C047\web\target\mapstore\WEB-INF\lib) are pointing to 1.7-SNAPSHOT in the pom.xml files in the project the target version is 1.7.1. I tried to build jars with version 1.7-SNAPSHOT but we are running into errors about geostore not being able to connect to data storage and retrieve resources (maps, geostories, etc) @taba90 we might need your help to build and deploy.

[nmco]

@taba90 is already out for today @ale-cristofori.

@taba90 let's have a look at this Tuesday morning, if needed we move the Vlaaderen call with Bert.