Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edr fixed axis #1811

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

pzaborowski
Copy link
Contributor

Overview

Related Issue / discussion

#1780

Additional information

Proposed change:

  • dismiss reordering of axes as it will not work without data transposition - can be done but is heavy
  • once metadata is ca;culated in query function, it is used in the serialisation 'covjson' not reading source data again. reading bbox and mint, maxt every time from source is confusing and easily generates inconsistencies in case of changes

Dependency policy (RFC2)

  • [ X] I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute bugfix Y to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Reading from query bbox and reversing the order would not work anyway if not followed by reversing data (which is not cheap and would not do on default. It is visible on the sample data tests/data/coads_sst.nc where the start-stop swapping turn the data upside down.
there is no sense in reading it from source file once again
@tomkralidis tomkralidis self-requested a review September 18, 2024 17:07
@tomkralidis tomkralidis added this to the 0.18.0 milestone Sep 18, 2024
@tomkralidis tomkralidis added the OGC API - Environmental Data Retrieval OGC API - Environmental Data Retrieval label Sep 18, 2024
pzaborowski and others added 7 commits September 19, 2024 12:26
1. time axis shall be 't' in covjson, for backward compliance it can be set with 'time_axis_covjson' provider variable. if time_axis_covjson is not set the value is read from time_field which has default value read from the source file.
2. time axis is now list of values according to specification and it is now properly rendered on the html view of the query
3. typo in query.html to fix error with first layer being not generated
1.integrated changes from axis fix
2. dataType is float according to schema https://schemas.opengis.net/covjson/1.0/coveragejson.json (number is not valid, float, integer, string are)
3. parameter description as object according to schema https://schemas.opengis.net/covjson/1.0/coveragejson.json
coards_sst.nc data was shifted around 180 deg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OGC API - Environmental Data Retrieval OGC API - Environmental Data Retrieval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants