Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe required collection level metadata about EDR Queries #1744

Merged
merged 14 commits into from
Jul 24, 2024

Conversation

webb-ben
Copy link
Member

Overview

Adds the necessary components to decribe EDR collections to work with EDR clients like
https://labs.metoffice.gov.uk/edr/static/html/query.html

Related Issue / discussion

#1151

Additional information

Demo running on this branch
image

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@webb-ben webb-ben added OGC API - Environmental Data Retrieval OGC API - Environmental Data Retrieval enhancement New feature or request labels Jul 20, 2024
@webb-ben webb-ben changed the title Add data_queries to describe EDR Queries Add data_queries to describe EDR Queries adequately Jul 20, 2024
@webb-ben webb-ben changed the title Add data_queries to describe EDR Queries adequately Describe collection level metadata about EDR Queries adequately Jul 21, 2024
@tomkralidis
Copy link
Member

Pausing until opengeospatial/ogcapi-environmental-data-retrieval#563 is addressed.

@webb-ben
Copy link
Member Author

webb-ben commented Jul 21, 2024

+1

I am interested in clarifying the extents.temporal.values field. It is present in the EDR spec for temporal extents, but not in the OAF
image

@tomkralidis
Copy link
Member

OGC API - Features does not imply a temporal model for collections. Feature data may or may not have a temporal aspect.

OGC API - Environmental Data Retrieval implies a more specific collection model given the temporal nature of the data it aims to support.

@webb-ben
Copy link
Member Author

As written, there is no differentiation between the OGC API - EDR and OGC API - Features temporal configuration. Should EDR collections be validated against https://schemas.opengis.net/ogcapi/edr/1.1/openapi/schemas/collections/extent.yaml?

Or is it fine as implemented in this PR?

@tomkralidis
Copy link
Member

pygeoapi only validates OpenAPI generation and config (not at runtime). For responses, we create the response as per the specification(s) and leave hard validation to CITE.

@webb-ben webb-ben closed this Jul 22, 2024
@webb-ben webb-ben reopened this Jul 22, 2024
@webb-ben webb-ben changed the title Describe collection level metadata about EDR Queries adequately Describe required collection level metadata about EDR Queries Jul 24, 2024
@tomkralidis tomkralidis merged commit 3adfdb2 into geopython:master Jul 24, 2024
4 checks passed
@webb-ben webb-ben deleted the edr-context branch September 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Environmental Data Retrieval OGC API - Environmental Data Retrieval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants