Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for get_job_result #1494

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

totycro
Copy link
Contributor

@totycro totycro commented Jan 15, 2024

This api method did not have any tests until now.

This also contains a small fix: If no content type was requested, then by default, the header specified the content type application/json, whereas the content was actually html. Note that this is rarely a problem because browsers do request html explicitly.

Overview

Related issue / discussion

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

This api method did not have any tests until now.

This also contains a small fix: If no content type was requested,
then by default, the header specified the content type
`application/json`, whereas the content was actually html. Note that
this is rarely a problem because browsers do request html explicitly.
@tomkralidis tomkralidis merged commit af5dbb8 into geopython:master Jan 15, 2024
4 checks passed
@totycro totycro deleted the test-for-job-result branch January 15, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants