Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on the pytz library. #921

Closed
wants to merge 0 commits into from

Conversation

spillner
Copy link

@spillner spillner commented Apr 7, 2024

Most of the Pytz functionality is now available in the standard library in 3.8 and greater, and the Pytz (https://pypi.org/project/pytz/) project has gone into maintenance mode and is no longer recommended for new projects. I noticed that OWSLib was using Pytz only to annotate timestamps as UTC, which doesn't even require the expanded tzinfo support from 3.8/3.9+; the attached patch supports Python 2 (at least Python 2.7) as well.

Copy link

github-actions bot commented Oct 6, 2024

This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Oct 6, 2024
@spillner
Copy link
Author

spillner commented Oct 7, 2024

Pinging the issue to prevent an auto-close. It looks like the CI pipelines were timing out due to a test harness issue that has nothing to do with this change, and the "conflict" in requirements.txt is a fundamental part of the patch.

Anyway, LMK if there's anything else you're looking for me to do to package this up.

@geographika
Copy link
Contributor

Thanks @spillner for this.
Python2 support has been dropped - and OWSLib requires Python 3.10 -

python_requires='>=3.10',
- does this make the patch even simpler?

@geographika
Copy link
Contributor

@spillner - the merge conflict is due to python-dateutil>=1.5 - the version can be removed so it looks as follows, and the CI should pass:

lxml
python-dateutil
pyyaml
requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants