Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: stop relying on array properties #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

format: stop relying on array properties #131

wants to merge 1 commit into from

Commits on Jan 21, 2022

  1. format: stop relying on array properties 

    There are numerous libraries out there (sugarjs, prototypejs) that
extend the `Array` prototype. The `simplify` function in js-quantities
relies on setting/checking properties on an array instance, which means
that it's incompatible with such libraries. Add compatibility by using a
separate object for keeping track of the counters instead of using
properties on array instances.

Fix gentooboontoo#130.

Signed-off-by: Kyle Fazzari <[email protected]>
    @kyrofa
    kyrofa committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    6b7bfcc View commit details
    Browse the repository at this point in the history