Add dub.eclass #131

the-horo · 2024-08-16T02:50:49Z

No description provided.

thesamesam · 2024-08-16T03:00:46Z

dev-util/dub/dub-1.38.1-r1.ebuild

+	local -x DFLAGS="${DCFLAGS} ${DLANG_LDFLAGS} $(dlang_get_wno_error_flag)"
+
+	# Run the unittests in the source files.
+	"${DUB}" test --verbose -c application


Missing die?

Or was this supposed to be edub?

No, it's missin the die. edub is not applicable as it will call the assumed to be installed dub, not the one which was just built. I don't think dub depending on dub is a good design so no calling edub.

The pattern for this is to inhibit dependencies in the eclass if CAT/PN = blah/dub but it can be a bit ugly. Not required at all, just a suggestion.

thesamesam · 2024-08-16T03:01:44Z

dev-util/serve-d/serve-d-0.8.0_beta17.ebuild

+S="${WORKDIR}/${PN}-${MY_PV}"
+LICENSE="MIT BSD"
+LICENSE+=" Apache-2.0 Boost-1.0 BSD GPL-3 LGPL-3 MIT openssl public-domain Unlicense"
+LICENSE+=" test? ( ISC public-domain )" # test dependencies. These do _not_ map to test? () in SRC_URI


Out of interest, why don't they map? Some of it is bundled I assume?

dub is very nice in that it will require that all possible dependencies to be satisfied when building something, even if, in that build, fewer things are needed. In this example, serve-d uses silly for tests. If silly is not present during dub build dub will fail. dub build does not use silly, only dub test so the license of silly I've put behind test?. There's probably more of these cases, at least both the openssl dependencies are unused as well though I didn't want to bother any more with this.

Upstream has an issue for this: dlang/dub#1706

thesamesam · 2024-08-16T03:02:12Z

dev-util/serve-d/serve-d-0.8.0_beta17.ebuild

+RESTRICT="!test? ( test )"
+
+# gdc currently fails due to a bug in mir-cpuid, see: https://github.com/libmir/mir-cpuid/pull/46
+DLANG_COMPAT=( dmd-2_{106..109} ldc2-1_{35..39} )


I'd consider trying to keep inherits all in one place and all eclass vars before inherit where possible. It's a lot easier to follow.

No objection.

thesamesam · 2024-08-16T03:03:06Z

eclass/dub.eclass

+	debug-print "${FUNCNAME}: DFLAGS=${DFLAGS}"
+
+	set -- dub --verbose "${@}"
+	echo "${@}"


This is edo

Bah, how come I only learn of this. I've read the devguide only up to the eclass reference before writing the eclass, such bad timing.

eclass/dub.eclass

thesamesam · 2024-08-16T03:04:21Z

sys-fs/btdu/btdu-0.5.1.ebuild

+KEYWORDS="~amd64"
+RESTRICT="test"
+
+RDEPEND="${DLANG_DEPS}"


The eclass should be setting this for us by default, right? (These variables accumulate when set by eclasses, see PMS)

Yeah, I think that's a better design. I guess I need to check if dlang-single or dlang-r1 has been inherited.

thesamesam

Looks pretty good!

thesamesam · 2024-08-17T02:24:33Z

dev-util/dub/dub-1.38.1-r1.ebuild

+		ewarn "precaution."
+		ewarn ""
+		ewarn "See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114171"
+		dlang-filter-dflags "gdc*" "-march=native"


I think you should pass -fno-tree-vectorize instead unconditionally with the bad GCC version, regardless of arch or DCFLAGS. That should avoid the miscompilation.

Or do tests fail with that?

thesamesam · 2024-08-17T02:25:07Z

dev-util/dub/dub-1.38.1-r1.ebuild

+}
+
+src_compile() {
+	local imports=source versions="DubApplication DubUseCurl"


This is OK but consider using arrays where they make sense.

thesamesam · 2024-08-17T02:25:26Z

dev-util/dub/dub-1.38.1-r1.ebuild

+	# Tries to connect to github.com and fails due to the network sandbox
+	rm -rf "${S}/test/git-dependency" || die
+	# Doesn't work on non amd64/x86
+	if [[ ${ARCH} == arm64 ]]; then


I would use a case statement and delete it on anything but amd64/x86 then.

thesamesam · 2024-08-17T02:26:06Z

dev-util/serve-d/serve-d-0.8.0_beta17.ebuild

+
+	# See https://issues.dlang.org/show_bug.cgi?id=24406 and
+	# https://github.com/Pure-D/serve-d/issues/360
+	# For short, we have to remove -O from DCFLAGS for dmd.


Suggested change

# For short, we have to remove -O from DCFLAGS for dmd.

# In short, we have to remove -O from DCFLAGS for dmd.

thesamesam · 2024-08-17T02:26:48Z

dev-util/serve-d/serve-d-0.8.0_beta17.ebuild

+	# Tries to update dependencies timing out for each one which sums up
+	# to about 4 minutes of doing nothing. There is no direct way to
+	# configure the code not to contact https://code.dlang.org
+	rm -rf tc_dub || die


I'm guilty of this all the time, but I should note that the use of -f in rm -f ... || die will suppress issues you often want to know about, e.g. the test being renamed.

thesamesam · 2024-08-17T02:32:33Z

eclass/dub.eclass

+			edo "${dubFetch[@]}" "${name}@${ver}"
+
+			# If it's the main package
+			[[ ${file} == ${PN}-$(ver_rs 3 - 4 .)* ]] \


This looks a bit gnarly and maybe a comment explaining why it's right wouldn't go amiss, but it might be obvious to someone who works with D a lot, so I don't insist.

thesamesam · 2024-08-17T02:32:48Z

sys-fs/btdu/btdu-0.5.1.ebuild

+
+EAPI=8
+
+# gdc-13 is disabled due to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111650


Nit:

Suggested change

# gdc-13 is disabled due to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111650

# gdc-13 is disabled due to: https://gcc.gnu.org/PR111650

thesamesam · 2024-08-17T02:33:01Z

sys-fs/btdu/btdu-0.5.1.ebuild

+	"[email protected]"
+	"[email protected]"
+)
+inherit dlang-single dub


Thanks for changing the style wrt var order. It's much easier to read now.

thesamesam · 2024-08-17T02:33:05Z

sys-fs/btdu/btdu-0.5.1.ebuild

+)
+inherit dlang-single dub
+
+DESCRIPTION="Sampling disk usage profiler for btrfs "


Suggested change

DESCRIPTION="Sampling disk usage profiler for btrfs "

DESCRIPTION="Sampling disk usage profiler for btrfs"

thesamesam · 2024-08-17T02:33:16Z

sys-fs/btdu/btdu-0.5.1.ebuild

+LICENSE+=" Boost-1.0 GPL-2 MIT MPL-2.0"
+SLOT="0"
+KEYWORDS="~amd64"
+RESTRICT="test"


Comment might be nice as to why?

Signed-off-by: Andrei Horodniceanu <[email protected]>

Additionally add missing dependency virtual/pkgconfig to RDEPEND. Signed-off-by: Andrei Horodniceanu <[email protected]>

Additional changes: - port to dub.eclass - run some more tests - install documentation on how to setup serve-d for various text editors Signed-off-by: Andrei Horodniceanu <[email protected]>

Signed-off-by: Andrei Horodniceanu <[email protected]>

thesamesam reviewed Aug 16, 2024

View reviewed changes

the-horo force-pushed the dub branch 2 times, most recently from 862e766 to ed999d2 Compare August 16, 2024 11:52

thesamesam approved these changes Aug 17, 2024

View reviewed changes

the-horo force-pushed the dub branch from ed999d2 to 9df552c Compare August 17, 2024 05:51

the-horo added 4 commits August 29, 2024 20:42

dub.eclass: new eclass

774c5d4

Signed-off-by: Andrei Horodniceanu <[email protected]>

dev-util/dub: use dub.eclass

e485b82

Additionally add missing dependency virtual/pkgconfig to RDEPEND. Signed-off-by: Andrei Horodniceanu <[email protected]>

dev-util/serve-d: add 0.8.0_beta17

da0cdc7

Additional changes: - port to dub.eclass - run some more tests - install documentation on how to setup serve-d for various text editors Signed-off-by: Andrei Horodniceanu <[email protected]>

sys-fs/btdu: new package, add 0.5.1

cf03de9

Signed-off-by: Andrei Horodniceanu <[email protected]>

the-horo force-pushed the dub branch from 9df552c to cf03de9 Compare August 30, 2024 07:30

gentoo-bot closed this in dd17942 Aug 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dub.eclass #131

Add dub.eclass #131

the-horo commented Aug 16, 2024

thesamesam Aug 16, 2024

thesamesam Aug 16, 2024

the-horo Aug 16, 2024

thesamesam Aug 16, 2024

thesamesam Aug 16, 2024

the-horo Aug 16, 2024

thesamesam Aug 16, 2024

the-horo Aug 16, 2024

thesamesam Aug 16, 2024

the-horo Aug 16, 2024

thesamesam Aug 16, 2024

the-horo Aug 16, 2024

thesamesam left a comment

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

thesamesam Aug 17, 2024

	# For short, we have to remove -O from DCFLAGS for dmd.
	# In short, we have to remove -O from DCFLAGS for dmd.


		EAPI=8

		# gdc-13 is disabled due to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111650

	DESCRIPTION="Sampling disk usage profiler for btrfs "
	DESCRIPTION="Sampling disk usage profiler for btrfs"

Add dub.eclass #131

Add dub.eclass #131

Conversation

the-horo commented Aug 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thesamesam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment