Fix lcov on Ubuntu Noble #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
tested with gazebosim/gz-fuel-tools#427 in gazebosim/gz-fuel-tools#428. the workflow passes, though there still seems like an issue with the codecov upload |
scpeters
approved these changes
Jul 20, 2024
|
uh oh, this breaks Ionic packages still using Jammy for coverage testing (see gazebosim/gz-utils#133) |
scpeters
added a commit
that referenced
this pull request
Jul 30, 2024
This reverts commit 930e17f. Signed-off-by: Steve Peters <[email protected]>
8 tasks
scpeters
added a commit
that referenced
this pull request
Jul 30, 2024
This reverts commit 930e17f. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The coverage build in gazebosim/gz-fuel-tools#427 is failing due to some issues in
lcov. From my testing and following the approach in ros2/ci#771, this PR seems to fix the problem.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.