Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bucket Lock immutable objects support for AWS S3 #818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ishan16696
Copy link
Member

What this PR does / why we need it:
This PR enables backup-restore to handle AWS S3's object lock mechanism which will make snapshots taken by backup-restore immutable. It also adjusted the Restoration and garbage collector functionality to handle immutable snapshots for S3 object store.

Which issue(s) this PR fixes:
Fixes #777

Special notes for your reviewer:
These case I have tested:

For Restoration functionality

  • Restoration functionality of backup-restore should work with buckets which don't have bucket/object lock enabled (Backward compatibility).
  • Restoration functionality of backup-restore should work with buckets which have both versioned immutable as well as non-immutable, non-versioned snapshots present.
  • Restoration functionality of backup-restore should work with buckets which have only immutable versioned snapshots(full as well as delta) present.

For Garbage collection of snapshots:

  • Backward compatibility with buckets which don't have immutability enabled.
  • GC should work with buckets which have both immutable as well as non immutable objects.
  • GC should work with buckets which have only immutable objects.

Release note:

etcd-backup-restore now supports immutable objects for storage provider: AWS S3, provided by the [Bucket Lock](https://aws.amazon.com/s3/features/object-lock/) feature.
Snapshots garbage collection performed by etcd-backup-restore (if enabled) for S3 is performed only when the snapshots's retention period get expires.
Support for Bucket lock (S3) in etcd-backup-restore is backward compatible. For more info please refer to this doc: https://github.com/gardener/etcd-backup-restore/blob/master/docs/usage/immutable_snapshots.md

@ishan16696 ishan16696 requested a review from a team as a code owner December 24, 2024 05:45
@gardener-robot gardener-robot added needs/review Needs review needs/rebase Needs git rebase labels Dec 24, 2024
@gardener-robot
Copy link

@ishan16696 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Dec 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 24, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.33.0 milestone Dec 24, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 25, 2024
…l make snapshots immutable.

Adjusted the Restoration and GC functionality to handle immutable snapshots for S3 object store.
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 25, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Dec 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
4 participants