Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend sharing bug #18942

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix backend sharing bug #18942

wants to merge 3 commits into from
+43 −9

Commits on Oct 4, 2024

  1. Refactor creation of sharing role towards testability

    @jdavcs
    jdavcs committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8b83424 View commit details
    Browse the repository at this point in the history

  2. Add test exposing bug 

    After user's email has been modified, we can't retrieve sharing roles
for that user
    @jdavcs
    jdavcs committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    00bebee View commit details
    Browse the repository at this point in the history

  3. Fix bug by using model association instead of string comparison

    @jdavcs
    jdavcs committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    806fe96 View commit details
    Browse the repository at this point in the history