Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow license and creator edit keyboard access #18936

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Oct 4, 2024

Closes #18915. This PR improves the LicenseSelector and CreatorEditor ui and makes them keyboard accessible. It also migrates LicenseSelector to composition API and typescript and uses GalaxyAPI to fetch license options and add new slots for inline buttons to License.

Workflow.license.and.creator.edit.keyboard.access.webm

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. In the workflow editor, access and edit license and creator via keyboard

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH added kind/enhancement area/accessibility Specifically for a11y issues; screenreader issues, etc. labels Oct 4, 2024
@itisAliRH itisAliRH marked this pull request as ready for review October 5, 2024 14:18
@github-actions github-actions bot added this to the 24.2 milestone Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility Specifically for a11y issues; screenreader issues, etc. area/UI-UX kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access workflow license save button via keyboard only
1 participant