Updating urls.py to be Django 2.0 through 4.0 compatibile #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The urls.py file was still using the pre Django 2.0 url function rather than re_path. re_path became the new standard in 2.0 and the old url() method will be removed in Django 4.0 so it may as well be removed now to allow this package to keep working
Updated to be Django 2.0 through 4.0 compatible
|
Any news on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 2.0 introduced the new
django.urls.re_pathfunction for url dispatching to replace the olddjango.conf.urls.urlfunction. The urls.py file within django-froala-editor was last updated to Django 1.9 which is dead anddjango.conf.urls.urlwill be removed in Django 4.0 therefore updating now will support not only the current LTS release of 2.2 but both the soon-to-be released 3.2 LTS release as well as Django 4.0