Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install .deb files and try to do conversions on them #20

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

almet
Copy link
Contributor

@almet almet commented Jun 14, 2024

This integrates with our CI to check that the files present in the repository are installable.

See the related discussion on the dangerzone repo

A few notes:

  1. For ubuntu, the name of the folders are different from the versions we were using, so I introduced a new version-name variable.

  2. I wasn't able to just mv files to the proper directories, but I'm not sure why. The docs say:

The steps of a job share the same environment on the runner machine, but run in their own individual processes.

After a few tries, I moved to using artefacts instead, which worked.

@apyrgio
Copy link
Contributor

apyrgio commented Jun 17, 2024

Looks great Alexis, thanks a lot for tackling it.

  1. For ubuntu, the name of the folders are different from the versions we were using, so I introduced a new version-name variable.

Cool. In theory you can use the Ubuntu codenames in our script as well (e.g., focal instead of 20.04. But there may be some landmines here and there, so don't fret.

  1. I wasn't able to just mv files to the proper directories, but I'm not sure why. The docs say:

I think I know what's going on. You're actually moving the symlink, which points to a relative path:

lrwxrwxrwx  1 runner docker   38 Jun 14 15:07 dangerzone_0.6.1-1_all.deb -> ../bookworm/dangerzone_0.6.1-1_all.deb

So, when you see that the code complains it can't find the file, it's actually the symlink that can't find the file.

I think cp would work here.

@almet
Copy link
Contributor Author

almet commented Jun 18, 2024 via email

@almet
Copy link
Contributor Author

almet commented Jun 18, 2024

I finally found what the problem was, connecting with ssh proved helpful to detect some bash expending problems in my script.

I've updated the PR accordingly (and squashed all these push-and-try commits). We should be good to merge.

@almet almet requested a review from apyrgio June 18, 2024 12:32
This spawns new jobs for each platform, which:

- Checkout the dangerzone repository ;
- Install the packages from this repository ;
- Start a conversion.
@apyrgio
Copy link
Contributor

apyrgio commented Jun 19, 2024

Nice one Alexis, feel free to merge 🙂

@almet almet merged commit cbf33ae into main Jun 19, 2024
16 checks passed
@almet almet deleted the 2024-06-install-images branch June 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants