-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install .deb files and try to do conversions on them #20
Conversation
Looks great Alexis, thanks a lot for tackling it.
Cool. In theory you can use the Ubuntu codenames in our script as well (e.g.,
I think I know what's going on. You're actually moving the symlink, which points to a relative path:
So, when you see that the code complains it can't find the file, it's actually the symlink that can't find the file. I think |
1. For ubuntu, the name of the folders are different from the versions
we were using, so I introduced a new version-name variable.
Cool. In theory you can use the Ubuntu codenames in our script as well
(e.g., focal instead of 20.04. But there may be some landmines here and
there, so don't fret.
Heh. Let's keep it like that for now then :-)
2. I wasn't able to just mv files to the proper directories, but I'm
not sure why. The docs say:
I think I know what's going on. You're actually moving the symlink,
which points to a relative path:
lrwxrwxrwx 1 runner docker 38 Jun 14 15:07 dangerzone_0.6.1-1_all.deb -> ../b
ookworm/dangerzone_0.6.1-1_all.deb
So, when you see that the code complains it can't find the file, it's
actually the symlink that can't find the file.
I think cp would work here.
Thanks for your comment! I unfortunately don't think that it is related to the
symlink, because it would trigger an "invalid file" error. Here I got a
"non-existing file" error.
In my previous commits (each of them triggered a CI run), I copied the file, and
checked it was there (with a `ls` command), and it was indeed the case.
In the following step I got an error, related to the file not being present
(magically disappearing)
My take was to use the artifacts to solve this, which worked, but feels suboptimal. I'll try to use this ssh action:
https://github.com/valeriangalliat/action-sshd-cloudflared
to debug (a bit) further.
|
cd1ade9
to
3bcc325
Compare
I finally found what the problem was, connecting with I've updated the PR accordingly (and squashed all these push-and-try commits). We should be good to merge. |
This spawns new jobs for each platform, which: - Checkout the dangerzone repository ; - Install the packages from this repository ; - Start a conversion.
3bcc325
to
cbf33ae
Compare
Nice one Alexis, feel free to merge 🙂 |
This integrates with our CI to check that the files present in the repository are installable.
See the related discussion on the dangerzone repo
A few notes:
For ubuntu, the name of the folders are different from the versions we were using, so I introduced a new
version-name
variable.I wasn't able to just
mv
files to the proper directories, but I'm not sure why. The docs say:After a few tries, I moved to using artefacts instead, which worked.