Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics when paths cannot be opened #86

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ngie-eign
Copy link
Contributor

@ngie-eign ngie-eign commented Dec 25, 2024

  • atf_utils_cat_file: output strerror(errno) to help diagnose what why the open call failed.
  • atf_utils_grep_file: output a message with the path name and strerror(errno) for parity with atf_utils_cat_file(..) and to make diagnosing problems without a corefile possible.

@ngie-eign ngie-eign requested a review from ihoro December 25, 2024 23:41
- atf_utils_cat_file: output `strerror(errno)` to help diagnose why
  the `open` call failed.
- atf_utils_grep_file: output a message with the path name and
  `strerror(errno)` for parity with `atf_utils_cat_file(..)` and to make
  diagnosing problems without a corefile possible.

Signed-off-by: Enji Cooper <[email protected]>
Copy link
Member

@ihoro ihoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngie-eign ngie-eign merged commit 34f422a into freebsd:master Dec 26, 2024
@ngie-eign ngie-eign deleted the improve-grep-diags branch December 26, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants