Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.1 #9

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Release 1.1.1 #9

merged 1 commit into from
Dec 23, 2024

Conversation

bessman
Copy link
Collaborator

@bessman bessman commented Dec 23, 2024

Summary by Sourcery

Release version 1.1.1, which fixes incorrect address checks in EraseFlash and CalculateChecksum.

Bug Fixes:

  • Fix address alignment check in EraseFlash.
  • Fix incorrect address check in CalculateChecksum.

Copy link

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This release fixes two bugs related to address checks in the bootloader:\n\n1. An incorrect address check in the CalculateChecksum function.\n2. A misaligned address check in the EraseFlash function.

Sequence diagram for fixed bootloader address checks

sequenceDiagram
    participant Host as Host Computer
    participant BL as Bootloader
    participant Flash as Flash Memory

    Host->>BL: Request Flash Erase
    Note over BL: Fixed address alignment check
    BL->>Flash: Erase Flash Memory
    Flash-->>BL: Erase Complete
    BL-->>Host: Operation Status

    Host->>BL: Calculate Checksum
    Note over BL: Fixed address range validation
    BL->>Flash: Read Memory Contents
    Flash-->>BL: Memory Data
    BL-->>Host: Checksum Result
Loading

File-Level Changes

Change Details Files
Fix address alignment check in EraseFlash
  • Added a changelog entry for the fix to the address alignment check in the EraseFlash function.
CHANGELOG.md
Fix incorrect address check in CalculateChecksum
  • Added a changelog entry for the fix to the incorrect address check in the CalculateChecksum function.
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bessman - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bessman bessman merged commit 2a4c67b into fossasia:main Dec 23, 2024
1 check passed
@bessman bessman deleted the rel/1.1.1 branch December 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant