Fix address alignment check in EraseFlash (close #5)

[bessman]

Summary by Sourcery

Bug Fixes:

• Fixed a bug where the address alignment check during flash erase operations was incorrect.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an address alignment check in the EraseFlash functionality by changing the data type of the FLASH_ERASE_PAGE_SIZE_IN_INSTRUCTIONS macro and related calculations from unsigned int (U) to unsigned long (UL). Additionally, it removes a redundant definition of FLASH_ERASE_PAGE_MASK from boot_process.c.

Class diagram showing Flash memory configuration changes

classDiagram
    class FlashConfig {
        +FLASH_ERASE_PAGE_SIZE_IN_INSTRUCTIONS: unsigned long
        +FLASH_ERASE_PAGE_SIZE_IN_PC_UNITS: unsigned long
        +FLASH_UNLOCK_KEY: uint32_t
        +FLASH_ERASE_PAGE_MASK: unsigned long
        +FLASH_Unlock(uint32_t key)
        +FLASH_Lock()
    }
    note for FlashConfig "Changed constants from unsigned int (U) to unsigned long (UL)
Removed duplicate FLASH_ERASE_PAGE_MASK definition"

Loading

File-Level Changes

Change	Details	Files
Updated FLASH_ERASE_PAGE_SIZE_IN_INSTRUCTIONS macro and related calculations to use unsigned long (UL) data type.	Changed FLASH_ERASE_PAGE_SIZE_IN_INSTRUCTIONS from 1024U to 1024UL. Modified related macro calculations to use UL consistently for correct address alignment. Updated FLASH_ERASE_PAGE_MASK calculation to use UL data type to maintain consistency and prevent potential alignment issues during erase operations.	src/mcc_generated_files/memory/flash.h
Removed redundant FLASH_ERASE_PAGE_MASK definition.	Removed the #ifndef FLASH_ERASE_PAGE_MASK block and its associated definition, as it duplicates the definition already present in flash.h.	src/mcc_generated_files/boot/boot_process.c

Possibly linked issues

• EraseFlash fails if address exceeds 0xFFFF #5: The PR fixes the integer overflow issue in FLASH_ERASE_PAGE_MASK by changing FLASH_ERASE_PAGE_SIZE_IN_INSTRUCTIONS from 1024U to 1024UL.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @bessman - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[bessman]

This PR was merged via command-line: 57167d1