Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Change Submission Content Page into a) Content Page as a View b) Content Edit Page #82

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

cbum-dev
Copy link

@cbum-dev cbum-dev commented Mar 15, 2024

Added content page and an edit button to edit the content.
Fixes issue #74

Checklist

  • I have added tests to cover my changes.
  • My change is listed in the doc/changelog.rst.
  • I have updated the documentation.

whitespace in newline check.
@cbum-dev
Copy link
Author

Please let me know why some checks are failing?

@mariobehling
Copy link
Member

Some tests are failing due to outdated versions. You achieved to keep the 7 tests working. Good. Please also add full page screenshots of the changes.

@cbum-dev
Copy link
Author

Screenshot from 2024-03-15 21-41-00
Screenshot from 2024-03-15 21-41-09
Screenshot from 2024-03-15 21-41-20

@mariobehling
Copy link
Member

Could you please test this with custom questions as well? E.g. add some questions into the "Questions Tab" and see if they show up here as well. If yes, please post screenshots.

@cbum-dev
Copy link
Author

Could you please test this with custom questions as well? E.g. add some questions into the "Questions Tab" and see if they show up here as well. If yes, please post screenshots.

Anything else which I should change or add?

@cbum-dev
Copy link
Author

Screenshot from 2024-03-16 19-04-58

@mariobehling

@mariobehling mariobehling requested a review from hongquan March 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants