Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Change Submission Content Page into a) Content Page as a View b) Content Edit Page #81

Closed
wants to merge 8 commits into from

Conversation

cbum-dev
Copy link

Added content page and an edit button to edit the content.
Fixes issue #74

How has this been tested?

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation.
  • My change is listed in the doc/changelog.rst.

@cbum-dev cbum-dev changed the title Fixes #74 Fixes issue #74 Mar 15, 2024
@cbum-dev
Copy link
Author

Screenshot from 2024-03-15 21-41-00
Screenshot from 2024-03-15 21-41-09
Screenshot from 2024-03-15 21-41-20

@mariobehling
Copy link
Member

I am unclear why there are three commits of @norbusan in this pull request.

@mariobehling mariobehling changed the title Fixes issue #74 Fixes Change Submission Content Page into a) Content Page as a View b) Content Edit Page Mar 15, 2024
@mariobehling
Copy link
Member

Please check failing tests. Previously 6 tests were failing. In this PR 7 tests are failing.

@cbum-dev
Copy link
Author

I am unclear why there are three commits of @norbusan in this pull request.

Should I again make a fresh PR, because I don't know how these commits are their.

@mariobehling
Copy link
Member

Ok, maybe a rebase could work, but if not try a fresh PR using the latest code, sure.

@cbum-dev cbum-dev closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants