Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for "Call for Speakers" #58

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Aryan20
Copy link
Contributor

@Aryan20 Aryan20 commented Feb 22, 2024

Fixes translation issues caused due to PR: #33

Related to issue - #46

The PR changes some other translations as well, which were automated by the Django makemessages module.
This can be caused due to the translations not being updated in past.

Fixes translation issues caused due to PR: fossasia#33
Copy link
Member

@marcoag marcoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few questions of removals I don't understand, can you please re-check the changes?

Comment on lines -4557 to -4560
#: pretalx/orga/templates/orga/base.html:404
msgid "Organisers"
msgstr "Organisateurs"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed? Isn't this still relevant for this:

<span>{% translate "Organisers" %}</span>
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! It is not removed but just moved up in the file.
That is automated. Probably translations changed somewhere but the file was not updated then.
Same applies for other messages as well.

image

Comment on lines -2952 to -2955
#: pretalx/mail/context.py:247
msgid "Jane Doe"
msgstr "Jane Doe"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer as the the other one

Comment on lines -2844 to -2847
#: pretalx/mail/context.py:247
msgid "Jane Doe"
msgstr "Fulanita de Tal"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this relevant for

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same answer applies here.

@Aryan20
Copy link
Contributor Author

Aryan20 commented Feb 27, 2024

@marcoag Yup. I reviewed and they are just moved to different places. The process is automated by Django makemessages.

@mariobehling mariobehling requested review from marcoag and norbusan March 6, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants